Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport two fixes for container #20028

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Backport two fixes for container #20028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc7bfe7
[BUGFIX LTS] remove bad `setFactoryFor` call
chriskrycho Mar 16, 2022
2590b2b
[BUGFIX beta] remove unneeded `setFactoryFor(this, this)`
chriskrycho Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/@ember/-internals/container/lib/container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Factory, LookupOptions, Owner, setOwner } from '@ember/-internals/owner';
import { dictionary, HAS_NATIVE_PROXY, HAS_NATIVE_SYMBOL, symbol } from '@ember/-internals/utils';
import { dictionary, HAS_NATIVE_PROXY, symbol } from '@ember/-internals/utils';
import { assert } from '@ember/debug';
import { assign } from '@ember/polyfills';
import { DEBUG } from '@glimmer/env';
Expand Down Expand Up @@ -558,11 +558,6 @@ class FactoryManager<T, C> {
this.normalizedName = normalizedName;
this.madeToString = undefined;
this.injections = undefined;
setFactoryFor(this, this);

if (isInstantiatable(container, fullName) && (HAS_NATIVE_SYMBOL || INIT_FACTORY in factory)) {
setFactoryFor(factory, this);
}
}

toString(): string {
Expand Down