Enable EMBER_TYPESCRIPT_BLUEPRINTS flag
#20352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
reviewed
Jan 18, 2023
|
@chriskrycho Done! Was mostly waiting on a "good to go", wasn't sure if we could already land this. |
26 tasks
|
Yeah, let me do a quick pass on the actual blueprints to make sure they're good, but/and we should have folks kick the tires a bunch during the 4.12 beta cycle—that’s what the beta cycle is for! |
|
We need to add the service registry to the service blueprints, but I believe we're otherwise good to go; I'm putting up a PR to do that now. |
|
Chatting with @cafreeman, he reminded me that we also need the blueprints to support generating signatures for components! And the same will go for helper classes, and we should make sure |
|
All right, let's do this! 🎉 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20177.