[FEATURE] generate type registry entry in service blueprint #20355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have support for this capability in the types, so the blueprints should make sure that there is a registry entry for each service. We originally left this out because we were unsure of the future of the service registry, but we made `Owner.lookup()` smart enough to resolve it, and the `@service` decorator continues to expect it.
chriskrycho
force-pushed
the
service-registry
branch
from
5d9391d to
cc58ddc
Compare
wagenet
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have support for this capability in the types, so the blueprints should make sure that there is a registry entry for each service. We originally left this out because we were unsure of the future of the service registry, but we made
Owner.lookup()smart enough to resolve it, and the@servicedecorator continues to expect it.Helps unblock #20352.