Inplement runtime portion of RFC #931 #20776
Conversation
wycats
force-pushed
the
feature/rfc-0931
branch
from
ee7de89
to
2f5e698
Compare
This commit fixes shadowing bugs in multiple AST transforms
This should be handled by a linter so it can be disabled where appropriate.
1. Document the type signature of the `template()` options. 2. Consolidate plugins into `@ember/template-compiler` and import them from `ember-template-compiler`. This commit also creates a few new entry points in `@ember/template-compiler` to satisfy the use-cases in the consolidation.
wycats
changed the title
This time in eval, where all the tooling in the world didn't notice it.
1. Re-export all of the plugins from locations in `ember-template-compiler/lib/plugins` to support the AMD compat entrypoints. I prioritized avoiding changes to the `amd-compat-entrypoints` file over absolutely minimizing the amount of duplication in `ember-template-compiler`. The implementations themselves are still not duplicated, but if we create new files in `@ember/template-compiler`, this may have implications for `ember-template-compiler`. 2. Fix a problem where `export import` in the barrel file wasn't playing nice with some piece of updated infrastructure. 3. Rename some of the exposed exports to include `-internal` in their module name.
This time, use an ambient `declare namespace` to declare the `Ember.RSVP` types, which will avoid the ill-fated attempt to transpile it at runtime using the babel typescript transform. The previous implementation already required us to dynamically install the `RSVP` property on the `Ember` object because the previous transpiler infrastructure didn't reliably handle this situation, so this is probably an improvement either way.
|
Safari 17.6 passes locally for me. According to: https://browsersl.ist/#q=%3E+0.25%25+and+not+dead I think we can bump to Safari 15.6 PR: #20779 |
| @@ -292,6 +292,30 @@ | |||
| "@ember/runloop/index.js": "ember-source/@ember/runloop/index.js", | |||
| "@ember/service/index.js": "ember-source/@ember/service/index.js", | |||
| "@ember/template-compilation/index.js": "ember-source/@ember/template-compilation/index.js", | |||
| "@ember/template-compiler/-internal-primitives.js": "ember-source/@ember/template-compiler/-internal-primitives.js", | |||
There was a problem hiding this comment.
just tested and this new stuff is not available outside of embroider 👍
|
I tried this out in an embroider app here: and it didn't work (seems like nothing is rendered?). maybe whatever is going on with CI will be resolved when this reproduction is resolved? |
|
Looks like there are two copies of Supposedly, I have sourcemaps turned off |
|
Your repro link is broken and this is not enough information to say what's going wrong. There are known module-duplication bugs that effect ember-source that are fixed only in the very latest |
I don't understand, the link works. Unless you mean something more specific?
in any case, I suppose for this feature we don't want to fix for embroider3? which means we have to disable/skip the failing test? |
|
I confirm things work as expected in the vite blueprint:
What not-working looks like in these tests |
|
I merged #20782 so this needs conflict fixes. |
No description provided.