Advance RFC #0931 "JS Representation of Template Tag" to Stage Ready for Release

[emberjs-rfcs-bot]

Advance #931 to the Ready For Release Stage

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

• PR to Accepted Stage: JS Representation of Template Tag #931

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

• Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
• Any necessary learning materials have been updated
• The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
• Criteria for moving to the Recommended Stage has been filled out
• This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
• Each team has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
  • Framework @emberjs/framework
  • Data @emberjs/ember-data-core
  • CLI @emberjs/cli
  • Learning @emberjs/learning-core
  • Typescript @emberjs/typescript-core
  • Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

• A version of babel-plugin-ember-template-compilation with support for @ember/template-compiler has been released and integrated into:
  • ember-cli-babel
    -[ ] embroider
• ember-template-imports has been updated so it uses a preprocessor that targets this format and relies on babel-plugin-ember-template-compilation instead of needing its own babel step.
• @ember/template-compiler/runtime is shipped, either as a real NPM package that we've aded to the blueprint or as a feature inside ember-source.
• update ember's own test suite t ouse the new runtime template compiler and stop always depending on the old template compiler bundle. Use this to re-enable testing of DEBUG_RENDER_TREE under prod settings.

Track Implementation

emberjs/babel-plugin-ember-template-compilation#21
https://github.com/embroider-build/content-tag/issues

[ef4]

Work is progressing on this. The build-time version is now in use, the runtime version needs work in ember-source.

[ef4]

The next significant blocker here is implementing the runtime version, which is going to depend on some cleanup of ember-source's own build and structure so that it can offer import-based inclusion of features.

[ef4]

Runtime template compiler has landed on ember main: emberjs/ember.js#20776

That makes it usable by embroider users. It will be usable by all users once we merge emberjs/ember.js#20787 and update the renamed-modules list to allow the runtime compiler even in classic builds.

After that we need to write docs for runtime template compiler.