Deprecate edge-case get and normalizeTuple behavior before fixes #4124
Conversation
|
This would be great to have in a release (or at least a beta release) before #3852 lands. That will give users a chance to get a nice warning and update. |
|
this may need a rebase. |
|
@stefanpenner rebased, for great good. |
|
Gave this another rebase to ensure that it is up to date- Is there anything else I can do to move it forward? |
|
@rjackson can you add this to the agenda today? |
|
@stefanpenner - Yep, already on there. |
|
awesome |
|
@stefanpenner Did this get discussed? |
|
Ping for tomorrow, if it can make the core discussion. |
|
Due to the recent update of ember-metal, ember-runtime, and ember-debug to ES6 module format, this PR does not apply cleanly any longer. @mixonic - Could you rebase? |
|
Rebased over the ES6 work and @stefanpenner's perf work. |
|
Rebased again and tests passing. |
|
I'd like to get this merged soon so that we can ship 1.7 with this deprecation warning. Does anyone have an objection to this? |
| if (obj === null) { | ||
| var value = _getPath(obj, keyName); | ||
| Ember.deprecate( | ||
| "Ember.get fetched '"+keyName+"' from the global context. This behavior will change in the future (issue #3852)", |
There was a problem hiding this comment.
I think we need a better message here. Perhaps make it more actionable?
|
And rebased again. |
…3852 PR emberjs#3852 changes some edge case behavior for get and normalizeTuple. Ahead of those changes, this commit introduces deprecation notices. * Deprecate get for local paths on global contexts, only if they return data. * Deprecate normalizeTuple calls that return a non-global contenxt and a simple global path.
Deprecate edge-case get and normalizeTuple behavior before fixes
Cleanup test failures from #4124.
Requires #4123.
PR #3852 changes some edge case behavior for get and normalizeTuple. Ahead of those changes, this commit introduces deprecation notices.
return data.
and a simple global path.
/cc @ebryn @wagenet