Revert #3218 and deprecate accessing global paths from Handlebars #4358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Progress
As discussed in #3218, this PR reverts the addition of the
ember-handlebars-caps-lookup
feature flag and adds a deprecation warning when global paths are accessed from a Handlebars template.I'm trying to fix the original inconsistency that was reported in #3098 (between
{{Foo}}
and{{#each Foo}}
) by changing bindings to look up values on the given context beforeEmber.lookup
. That part is incomplete and I'm not really sure what to change to get the rest of those tests to pass. Would love to be pointed in the right direction there.I'm also not sure if it's possible to add a deprecation notice in the
{{#each Foo}}
case since the binding doesn't know whether it's being created from a template or not.cc @ebryn