Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3218 and deprecate accessing global paths from Handlebars #4358

Closed
wants to merge 4 commits into from

Conversation

xtian
Copy link
Contributor

@xtian xtian commented Feb 13, 2014

In Progress

As discussed in #3218, this PR reverts the addition of the ember-handlebars-caps-lookup feature flag and adds a deprecation warning when global paths are accessed from a Handlebars template.

I'm trying to fix the original inconsistency that was reported in #3098 (between {{Foo}} and {{#each Foo}}) by changing bindings to look up values on the given context before Ember.lookup. That part is incomplete and I'm not really sure what to change to get the rest of those tests to pass. Would love to be pointed in the right direction there.

I'm also not sure if it's possible to add a deprecation notice in the {{#each Foo}} case since the binding doesn't know whether it's being created from a template or not.

cc @ebryn

@xtian
Copy link
Contributor Author

xtian commented Feb 13, 2014

�Related: #3436

@stefanpenner
Copy link
Member

you have upset travis

@ebryn
Copy link
Member

ebryn commented Feb 21, 2014

@xtian ping re: failing travis build

@mixonic
Copy link
Member

mixonic commented Feb 23, 2014

#3852 and #4124 are addressing the root cause of this.

Actually, sorry, that is not true. They address the inconsistency, but don't say anything about what can or cannot be accessed from a template.

@ebryn
Copy link
Member

ebryn commented Feb 28, 2014

@xtian ping again
@mixonic - if @xtian doesn't get back to this soon, could you take over this?

@mixonic
Copy link
Member

mixonic commented Feb 28, 2014

I think the template level changes here seem reasonable. I'm far less sold on the changes to packages/ember-metal/lib/binding.js. Additional tests need to be added for the deprecation imo and from the test output it looks like there are many tests that should be updated to not reference a global (looots of deprecation notices in that output).

I'll take a fast stab soon if @xtian wants to pass the torch.

@ebryn
Copy link
Member

ebryn commented Mar 2, 2014

@mixonic Looks like he's MIA, could you take over?

@xtian xtian closed this Mar 2, 2014
rwjblue added a commit that referenced this pull request Jul 25, 2014
Revert #3218, replace #4358. Deprecate global access from templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants