[FEATURE ember-routing-fire-activate-deactivate-events] Fire activate and deactivate events on Ember.Route
#5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pangratz has this been discussed with anyone yet? |
…e` and `deactivate` events on `Ember.Route` Additionally to the existing `activate` and `deactivate` hooks on `Ember.Route`, this feature adds the firing of events with the same name on the route. This closes #4923
|
I needed this today, it would be super fab to have it. @machty |
machty
added a commit
that referenced
this pull request
Oct 20, 2014
…_to_route [FEATURE ember-routing-fire-activate-deactivate-events] Fire `activate` and `deactivate` events on `Ember.Route`
|
@machty thank you sir, you are my hero
|
|
Sorry, been negligent. But it's amazing the kudos you get for pressing a green button. |
|
You're like that parent who is always late to pick you up from school but then takes you for ice cream. 🍦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally to the existing
activateanddeactivatehooks onEmber.Route, this feature adds the firing of events with the same nameon the route.
This closes #4923