This repository has been archived by the owner on Oct 25, 2018. It is now read-only.
WIP: Reworking search for v2.3.0 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acorncom
commented
May 19, 2016
•
acorncom
commented
- updated to use revised search index, facet filters and api key as seen in emberjs/guides@73a1aa1
- needs CSS redone
- needs search HTML reworked across all pages
- address all TODOs
| this.available = available.sort(compareVersions).reverse(); | ||
|
|
||
| // @TODO: have to work through how this gets populated when we're using a global js include on an older version of Ember | ||
| this.current = 'CURRENT_REVISION_WILL_APPEAR_HERE_WHEN_DEPLOYED'; |
There was a problem hiding this comment.
Our current window.GUIDE_VERSIONS hard-codes current. Seems like we'd need to pull it from the URL of the page we're looking at instead if we're going to be using this globally ...
There was a problem hiding this comment.
maybe a relative src in a script tag?
1 task
|
Reopening, we were just testing things |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.