Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Change search provider to DocSearch #1202

Closed

Conversation

jeradg
Copy link
Contributor

@jeradg jeradg commented Jan 28, 2016

(Reopening #1188)

This PR changes the Guides search provider from Swiftkey to DocSearch.

See issues #1184 and #1183 for discussion.

Functionality checked in Chrome and Firefox latest.

Todo:

  • More browser testing

Screenshots

Small width:
docsearch-small-width

Large width:
docsearch-large

Typo correction:
docsearch-spellcheck

…Search

Removed Swiftype gem, scripts and styles.

Added DocSearch scripts and styles.

Changed default DocSearch colours to Ember colours.

Fixed alignment problem with search input at small screen sizes.

Added padding above version select at small screen sizes.
@locks locks added this to the Future milestone Jan 28, 2016
@homu
Copy link
Contributor

homu commented Mar 8, 2016

☔ The latest upstream changes (presumably #1312) made this pull request unmergeable. Please resolve the merge conflicts.

@acorncom acorncom mentioned this pull request May 19, 2016
1 task
@acorncom
Copy link
Contributor

Closing this, as I'm handling merge conflicts and a few other tweaks in the PR referenced above. Thanks very much for your work on this!

@acorncom acorncom closed this May 19, 2016
@jeradg
Copy link
Contributor Author

jeradg commented May 19, 2016

@acorncom: My pleasure. Let me know if you'd like a hand wrapping this up.

@acorncom
Copy link
Contributor

@jeradg I wouldn't say no, it's going to get kind of tedious ;-)

emberjs/guides.emberjs.com#19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants