Deprecate Ember Array

[wagenet]

Propose Deprecating Ember Array

Rendered

Summary

This pull request is proposing a new RFC to Deprecate Ember Array.

To succeed, it will need to pass into the Exploring Stage, followed by the Accepted Stage.

A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.

An FCP is required before merging this PR to advance to Accepted.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.

Exploring Stage Description

This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage.

An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an Exploring label applied.

An Exploring RFC that is successfully completed can move to Accepted with an FCP is required as in the existing process. It may also be moved to Closed with an FCP.

Accepted Stage Description

To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams.

If there are unanswered questions, we have outlined them and expect that they will be answered before Ready for Release.

When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the Ready for Release stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.

Checklist to move to Exploring

• The team believes the concepts described in the RFC should be pursued.
• The label S-Proposed is removed from the PR and the label S-Exploring is added.
• The Ember team is willing to work on the proposal to get it to Accepted

Checklist to move to Accepted

• This PR has had the Final Comment Period label has been added to start the FCP
• The RFC is announced in #news-and-announcements in the Ember Discord.
• The RFC has complete prose, is well-specified and ready for implementation.
  • All sections of the RFC are filled out.
  • Any unanswered questions are outlined and expected to be answered before Ready for Release.
  • "How we teach this?" is sufficiently filled out.
• The RFC has a champion within one of the relevant teams.
• The RFC has consensus after the FCP period.

[kategengler]

This needs the deprecation guide written.

[ef4]

Let's make sure this document lists the importable paths we're deprecating as well (it currently uses the old global names like Ember.Array as opposed to import statements).

[ef4]

The content for the deprecation guide looks good, the exact details of which deprecations IDs get used can vary when we go to implement them.

[kategengler]

I think it would be good to list the imports

[Eredrim]

In my opinion it's a pity EmberArray and MutableArray are deprecated (to be removed afterward). They contain many helpers that make possible to save a lot of time comparing to vanilla JS arrays. Maybe you should deprecate them and remove them from ember-core, but in the same time create an add-on (for instance "Ember Array Wrappers") to offer an optional usage of these useful wrappers, even if it means reimplement them using vanilla arrays and tracked-built-in.
I would add this option would make migration to next Ember versions easier.

[NullVoxPopuli]

@Eredrim some options for ya:

• https://github.com/tracked-tools/tracked-built-ins 's TrackedArray (tho a built in trackedArray will be shipping in ember 6.8)
• I made an addon to re-add back prototype extensions: https://github.com/NullVoxPopuli/legacy-prototype-extensions -- at the moment this extends from ember/array's NativeArray, but when this deprecation ships, all that code would be moved in to this library, probably
• use more popular / well tested utilities, such as any of these: https://www.npmjs.com/search?q=array%20utilities

[Eredrim]

Hi!
Thanks for your quick answer. I didn't have any doubts about trackedArray would become the new standard (and that's great!). My question was about all the utility commands (like findBy(), rejectBy(), uniqueBy(), etc) that are really useful as of today's date. Following your advice, I searched for similar plugins in npmjs.com, and the most similar stuff I found was Collect.js, that is super complete but really different.
I think the best option for my need is to use your "legacy-prototype-extensions" plugin. I hope you will be able to migrate the code from ember to it. It would be the best solution for me.

[kategengler]

@Eredrim and others looking for the array convenience methods: There's an in-depth deprecation guide from when we deprecated the array prototype extensions that shows how to replace the behavior https://deprecations.emberjs.com/id/deprecate-array-prototype-extensions