-
-
Notifications
You must be signed in to change notification settings - Fork 407
Deprecate Ember Array #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deprecate Ember Array #1114
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| --- | ||
| stage: accepted | ||
| start-date: 2025-06-13T00:00:00.000Z | ||
| release-date: | ||
| release-versions: | ||
| teams: # delete teams that aren't relevant | ||
| - cli | ||
| - data | ||
| - framework | ||
| - learning | ||
| - typescript | ||
| prs: | ||
| accepted: https://github.com/emberjs/rfcs/pull/1114 | ||
| project-link: | ||
| --- | ||
|
|
||
| # Deprecating Ember Array | ||
|
|
||
| ## Summary | ||
|
|
||
| Deprecate `Ember.Array`, `Ember.MutableArray`, `Ember.ArrayProxy`, `Ember.NativeArray`, `Ember.A`, | ||
| `Ember.Enumerable` and Array computed macros. | ||
|
|
||
| ## Motivation | ||
|
|
||
| Now that Ember has a proper tracking system and the availability of `tracked-built-ins` we no longer | ||
| need our own custom arrays. In addition, much of the internal implementation relies upon Mixins which | ||
| we also hope to deprecate in the future. | ||
|
|
||
| ## Transition Path | ||
|
|
||
| All uses of custom Arrays should be replaced with native Arrays and `tracked-built-ins`. | ||
| Additionally, computed macros should be updated to use tracked getters. | ||
|
|
||
| Given how estabished these patterns are, we probably want to provide an addon that brings | ||
| back at least some of the functionality to aid migration. | ||
|
|
||
| ## Exploration | ||
|
|
||
| To validate this deprecation, I've tried removing EmberArray in this PR: | ||
| https://github.com/emberjs/ember.js/pull/20921 | ||
|
|
||
| ## How We Teach This | ||
|
|
||
| We should replace any references in the guides with native arrays or `TrackedArray`. | ||
|
|
||
| ## Drawbacks | ||
|
|
||
| This functionality is old and very well established, removing it will not be without pain | ||
| to many users. | ||
|
|
||
| ## Alternatives | ||
|
|
||
| Deprecate just `Ember.A`: #864 | ||
|
|
||
| ## Unresolved questions | ||
|
|
||
| None | ||
|
|
||
| ## Notes | ||
|
|
||
| This overlaps with #1112 which also seeks to deprecate `Ember.ArrayProxy`. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to list the imports