Skip to content

Commit

Permalink
Add linker flag to make library compatible with 16 kb page sizes. (#1126
Browse files Browse the repository at this point in the history
)

* Add linker flag to make library compatible with devices with a 16kb memory page size

* Update NDK version to 22.1.7171670.
  • Loading branch information
priettt authored Jul 26, 2024
1 parent 5912869 commit 07055e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/io/embrace/gradle/Versions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ object Versions {
// kotlin 1.9 required before any further upgrades
const val DETEKT = "1.23.6"

const val NDK = "21.4.7075529"
const val NDK = "22.1.7171670"
const val MOCKK = "1.12.2"
const val ANDROIDX_TEST = "1.4.0"
const val ANDROIDX_JUNIT = "1.1.3"
Expand Down
1 change: 1 addition & 0 deletions embrace-android-sdk/src/main/cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ set_target_properties(embrace-native

add_subdirectory(3rdparty/libunwindstack-ndk/cmake)
target_link_libraries(embrace-native unwindstack)
target_link_options(embrace-native PRIVATE "-Wl,-z,max-page-size=16384")
if (${ANDROID_ABI} STREQUAL "armeabi" OR ${ANDROID_ABI} STREQUAL "armeabi-v7a")
add_library(libunwind STATIC IMPORTED)
set_target_properties(libunwind PROPERTIES IMPORTED_LOCATION
Expand Down

0 comments on commit 07055e0

Please sign in to comment.