Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linker flag to make library compatible with 16 kb page sizes. #1126

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Jul 18, 2024

Adding this allows our library to work on devices with a 16kb memory page size.

If we don't do this, even if the customer has ndk_enabled set to false, the app will crash with a SIGSEGV when we try to load the native library.

This was done following the steps here: https://developer.android.com/guide/practices/page-sizes

I verified the correct alignment of the test apk after the changes using the alignment script here: https://developer.android.com/guide/practices/page-sizes#test

@priettt priettt requested a review from a team as a code owner July 18, 2024 14:18
Copy link
Contributor

github-actions bot commented Jul 18, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (5912869) to head (14aefa9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   83.00%   82.92%   -0.08%     
==========================================
  Files         433      433              
  Lines       11278    11278              
  Branches     1755     1755              
==========================================
- Hits         9361     9352       -9     
- Misses       1137     1145       +8     
- Partials      780      781       +1     

see 2 files with indirect coverage changes

@priettt priettt force-pushed the android-15-native-fix branch 2 times, most recently from f0543b4 to f172e8a Compare July 22, 2024 17:57
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This doesn't change the NDK version customers an use right? The deps are all built into individual .so files and there's no dynamic linking at runtime or cross .so calls?

@priettt priettt force-pushed the android-15-native-fix branch from f172e8a to 14aefa9 Compare July 26, 2024 17:13
@priettt priettt merged commit 07055e0 into master Jul 26, 2024
6 checks passed
@priettt priettt deleted the android-15-native-fix branch July 26, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants