Merge pull request #51 from embrace-io/alter-periodic-caching

Alter how periodic session caching works
embrace-io · Nov 13, 2023 · 3d9b6e1 · 3d9b6e1
2 parents ea815e8 + 9f72815
commit 3d9b6e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/session/SessionHandler.kt b/embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/session/SessionHandler.kt
@@ -544,7 +544,7 @@ internal class SessionHandler(
         }
 
         try {
-            this.automaticSessionStopper.scheduleAtFixedRate(
+            this.automaticSessionStopper.scheduleWithFixedDelay(
                 automaticSessionStopperCallback,
                 maxSessionSeconds.toLong(),
                 maxSessionSeconds.toLong(),
@@ -592,7 +592,7 @@ internal class SessionHandler(
      */
     private fun startPeriodicCaching(cacheCallback: Runnable) {
         try {
-            scheduledFuture = this.sessionPeriodicCacheExecutorService.scheduleAtFixedRate(
+            scheduledFuture = this.sessionPeriodicCacheExecutorService.scheduleWithFixedDelay(
                 cacheCallback,
                 0,
                 SESSION_CACHING_INTERVAL.toLong(),

diff --git a/...ace-android-sdk/src/test/java/io/embrace/android/embracesdk/session/SessionHandlerTest.kt b/...ace-android-sdk/src/test/java/io/embrace/android/embracesdk/session/SessionHandlerTest.kt
@@ -211,7 +211,7 @@ internal class SessionHandlerTest {
         assertEquals(1, gatingService.sessionMessagesFiltered.size)
         // verify automatic session stopper has been scheduled
         verify {
-            mockAutomaticSessionStopper.scheduleAtFixedRate(
+            mockAutomaticSessionStopper.scheduleWithFixedDelay(
                 mockAutomaticSessionStopperRunnable,
                 maxSessionSeconds.toLong(),
                 maxSessionSeconds.toLong(),
@@ -220,7 +220,7 @@ internal class SessionHandlerTest {
         }
         // verify periodic caching worker has been scheduled
         verify {
-            mockSessionPeriodicCacheExecutorService.scheduleAtFixedRate(
+            mockSessionPeriodicCacheExecutorService.scheduleWithFixedDelay(
                 mockPeriodicCachingRunnable,
                 0,
                 SESSION_CACHING_INTERVAL.toLong(),