Alter how periodic session caching works #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 74.67% 74.67%
=======================================
Files 308 308
Lines 10095 10095
Branches 1448 1448
=======================================
Hits 7538 7538
Misses 1982 1982
Partials 575 575
|
|
Sweet. I was just looking at this today and if we have big session payloads, it could lead to a tonne of GC and lmkd kills once we background! |
bidetofevil
reviewed
Nov 10, 2023
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/session/SessionHandler.kt
Outdated
Show resolved
Hide resolved
bidetofevil
reviewed
Nov 10, 2023
embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/session/SessionHandler.kt
Outdated
Show resolved
Hide resolved
bidetofevil
approved these changes
Nov 10, 2023
|
@bidetofevil I made a few changes based on your comments to use |
fractalwrench
force-pushed
the
alter-periodic-caching
branch
from
500b16e to
d9f33e4
Compare
fractalwrench
force-pushed
the
alter-periodic-caching
branch
from
d9f33e4 to
ea815e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Embrace periodicially caches sessions on disk to handle the case that a crash might lead to data loss. While this is something we ultimately want to move away from, for now I've refactored the existing implementation so that it handles backpressure more gracefully.
Previously we were using a
ScheduledExecutorServicethat executes a runnable at a fixed interval. This works fine for most purposes, but if the device is under severe strain then the executor service is unlikely to keep up, and will have a large queue of jobs to churn through (ironically causing more strain). Historically we had the same problem with ANR data capture.I've therefore refactored the logic so that after each cache a new job is scheduled for the given interval.
Testing
Relied on existing test coverage & manually verified that cached sessions make it through to the dash. I also checked that the interval is more or less the same: