Turn on Spans by default (#43)

## Goal Spans will be on by default
embrace-io · Nov 7, 2023 · ce8a627 · ce8a627
2 parents 978a47a + 0f412ba
commit ce8a627
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/embrace-android-sdk/src/androidTest/assets/golden-files/session-end.json b/embrace-android-sdk/src/androidTest/assets/golden-files/session-end.json
@@ -105,5 +105,6 @@
     "un": "John Doe",
     "per": ["first_day"]
   },
+  "spans": "__EMBRACE_TEST_IGNORE__",
   "v": 13
 }
diff --git a/...-android-sdk/src/main/java/io/embrace/android/embracesdk/config/behavior/SpansBehavior.kt b/...-android-sdk/src/main/java/io/embrace/android/embracesdk/config/behavior/SpansBehavior.kt
@@ -11,7 +11,7 @@ internal class SpansBehavior(
     remoteSupplier
 ) {
     companion object {
-        private const val DEFAULT_PCT_ENABLED = 0.0f
+        private const val DEFAULT_PCT_ENABLED = 100.0f
     }
 
     fun isSpansEnabled(): Boolean {

diff --git a/...roid-sdk/src/test/java/io/embrace/android/embracesdk/config/behavior/SpansBehaviorTest.kt b/...roid-sdk/src/test/java/io/embrace/android/embracesdk/config/behavior/SpansBehaviorTest.kt
@@ -2,7 +2,6 @@ package io.embrace.android.embracesdk.config.behavior
 
 import io.embrace.android.embracesdk.config.remote.SpansRemoteConfig
 import io.embrace.android.embracesdk.fakes.fakeSpansBehavior
-import org.junit.Assert.assertFalse
 import org.junit.Assert.assertTrue
 import org.junit.Test
 
@@ -14,7 +13,7 @@ internal class SpansBehaviorTest {
     @Test
     fun testDefaults() {
         with(fakeSpansBehavior()) {
-            assertFalse(isSpansEnabled())
+            assertTrue(isSpansEnabled())
         }
     }
 

diff --git a/...sdk/src/test/java/io/embrace/android/embracesdk/internal/spans/EmbraceSpansServiceTest.kt b/...sdk/src/test/java/io/embrace/android/embracesdk/internal/spans/EmbraceSpansServiceTest.kt
@@ -46,6 +46,7 @@ internal class EmbraceSpansServiceTest {
 
     @Test
     fun `initializing service if the config is not on won't actually initialize it`() {
+        spansRemoteConfig = SpansRemoteConfig(pctEnabled = 0f)
         configService.updateListeners()
         spansService.initializeService(1, 5)
         configService.updateListeners()