Turn on Spans by default #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 73.76% 73.75% -0.01%
==========================================
Files 305 305
Lines 10053 10053
Branches 1447 1447
==========================================
- Hits 7416 7415 -1
Misses 2067 2067
- Partials 570 571 +1
|
bidetofevil
commented
Nov 4, 2023
| @@ -105,5 +105,6 @@ | |||
| "un": "John Doe", | |||
| "per": ["first_day"] | |||
| }, | |||
| "spans": "__EMBRACE_TEST_IGNORE__", | |||
There was a problem hiding this comment.
Adding validation in next PR when the issue of double-logging fixed if the moment ends in a timeout
bidetofevil
force-pushed
the
hho/tracing-on
branch
from
364447f to
0f412ba
Compare
nelsitoPuglisi
approved these changes
Nov 7, 2023
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Spans will be on by default