Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the method to get all the outstanding network calls #100

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Nov 20, 2023

Goal

This is a clearer way of articulating what this is doing. I really like the verb/noun "snapshot" as it gives a name to a slice in time of whatever state we are trying to capture.

Copy link
Collaborator Author

@bidetofevil bidetofevil marked this pull request as ready for review November 20, 2023 23:25
@bidetofevil bidetofevil requested a review from a team as a code owner November 20, 2023 23:25
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #100 (b2817db) into hho/network-logging-synch (3e516aa) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           hho/network-logging-synch     #100   +/-   ##
==========================================================
  Coverage                      75.73%   75.73%           
==========================================================
  Files                            314      314           
  Lines                          10070    10070           
  Branches                        1459     1459           
==========================================================
  Hits                            7627     7627           
  Misses                          1850     1850           
  Partials                         593      593           
Files Coverage Δ
...mbracesdk/capture/EmbracePerformanceInfoService.kt 64.28% <100.00%> (ø)
...dk/network/logging/EmbraceNetworkLoggingService.kt 87.80% <ø> (ø)

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from hho/network-logging-synch to master November 21, 2023 16:21
@bidetofevil bidetofevil merged commit d0c314f into master Nov 21, 2023
3 checks passed
@bidetofevil bidetofevil deleted the hho/rename-method branch November 21, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants