Synchronize network call logging

[bidetofevil]

Goal

Properly synchronize the update and fetching of network calls. The previous strategy only accounted for the modification of the network call storage, but left limits tracking and limit overage reporting open to race conditions. This change makes sure that while a network call is being logged, we can't fetch a current snapshot for the session payload.

Also, we were trying to be clever about when when to lock when we take the snapshot, but it just didn't work (i.e. the things can change once the calls were fetched but before the payload is returned). As much as we can, we put work outside the synchronization block if we could (i.e. when we validate the staleness of the cache, which should not be a problem now), but in most cases, the locking isn't too bad (i.e. cache read and limits overage data construction), and all we're blocking are background threads. So this should be OK? *sweat_smile

Testing

Existing tests pass. The stateless internal error was happening once every ~650 session or so, and this change should bring it down to 0

[bidetofevil]

Current dependencies on/for this PR:

• master
  • PR Synchronize network call logging #99 👈
    • PR Change the name of the method to get all the outstanding network calls #100

This stack of pull requests is managed by Graphite.

[codecov]

Codecov Report

Merging #99 (3e516aa) into master (52b6edc) will increase coverage by 0.00%.
The diff coverage is 81.63%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   75.73%   75.73%           
=======================================
  Files         314      314           
  Lines       10068    10070    +2     
  Branches     1459     1459           
=======================================
+ Hits         7625     7627    +2     
  Misses       1850     1850           
  Partials      593      593           

Files	Coverage Δ
...dk/network/logging/EmbraceNetworkLoggingService.kt	87.80% <81.63%> (+0.20%)	⬆️

[fractalwrench]

LGTM