Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename methods in ActivityLifecycleListenerInterface to match lifecycle methods #1123

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jul 18, 2024

Goal

Remove the bespoke names and use names that match the lifecycle method that the methods actually map to. This will enable future changes to be more understandable.

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.50%. Comparing base (92d840a) to head (fa010ed).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files         439      439           
  Lines       11546    11546           
  Branches     1789     1789           
=======================================
  Hits         9410     9410           
  Misses       1352     1352           
  Partials      784      784           
Files Coverage Δ
...nternal/capture/crumbs/EmbraceBreadcrumbService.kt 59.25% <ø> (ø)
...rnal/session/lifecycle/ActivityLifecycleTracker.kt 88.63% <100.00%> (ø)
...nal/session/lifecycle/ActivityLifecycleListener.kt 0.00% <0.00%> (ø)

@bidetofevil bidetofevil force-pushed the hho/rename-activity-listener branch from e077e6c to fa010ed Compare July 25, 2024 18:35
@bidetofevil bidetofevil marked this pull request as ready for review July 25, 2024 18:53
@bidetofevil bidetofevil requested a review from a team as a code owner July 25, 2024 18:53
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the old name </sarcasm>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants