-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emb.type for spans that track activity opening #1318
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bidetofevil and the rest of your teammates on Graphite |
8f4abf5
to
b2a70f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1318 +/- ##
==========================================
+ Coverage 82.84% 82.91% +0.07%
==========================================
Files 484 485 +1
Lines 11041 11052 +11
Branches 1699 1705 +6
==========================================
+ Hits 9147 9164 +17
+ Misses 1152 1143 -9
- Partials 742 745 +3
|
989087d
to
0d45b03
Compare
b2a70f7
to
c1e9a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0d45b03
to
e03990c
Compare
c1e9a6b
to
98b5021
Compare
e03990c
to
965686a
Compare
98b5021
to
cfe2c83
Compare
cfe2c83
to
48eaf5c
Compare
48eaf5c
to
dff3659
Compare
dff3659
to
ca6179d
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Merge activity
|
Goal
Created a new
emb.type
for these types of traces. The name is not finalized but lets merge it as it is because tests are built on top of this. We can rename everything once finalize the proper name.