Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emb.type for spans that track activity opening #1318

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Sep 3, 2024

Goal

Created a new emb.type for these types of traces. The name is not finalized but lets merge it as it is because tests are built on top of this. We can rename everything once finalize the proper name.

Copy link
Collaborator Author

bidetofevil commented Sep 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (27567c7) to head (ca6179d).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
+ Coverage   82.84%   82.91%   +0.07%     
==========================================
  Files         484      485       +1     
  Lines       11041    11052      +11     
  Branches     1699     1705       +6     
==========================================
+ Hits         9147     9164      +17     
+ Misses       1152     1143       -9     
- Partials      742      745       +3     
Files with missing lines Coverage Δ
...android/embracesdk/internal/arch/schema/EmbType.kt 89.79% <100.00%> (+0.21%) ⬆️
...id/embracesdk/internal/spans/EmbraceSpanBuilder.kt 94.28% <100.00%> (ø)

... and 6 files with indirect coverage changes

@bidetofevil bidetofevil force-pushed the hho/open-activity-type branch from b2a70f7 to c1e9a6b Compare September 9, 2024 18:25
@bidetofevil bidetofevil marked this pull request as ready for review September 9, 2024 18:31
@bidetofevil bidetofevil requested a review from a team as a code owner September 9, 2024 18:31
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/open-activity-type branch from dff3659 to ca6179d Compare September 13, 2024 06:08
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator Author

bidetofevil commented Sep 13, 2024

Merge activity

@bidetofevil bidetofevil merged commit aa495a3 into main Sep 13, 2024
7 of 8 checks passed
@bidetofevil bidetofevil deleted the hho/open-activity-type branch September 13, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants