Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create annotation to opt into activity open tracing #1345

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Sep 11, 2024

Goal

Restrict the activities for which loading will be traced. Initially, we will look for a specific annotation on an Activity, but ways to specify this will be added in later PRs.

Testing

Add unit tests

@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 0e1d93e to 044d183 Compare September 11, 2024 05:02
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 71032f6 to cb09170 Compare September 11, 2024 05:02
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 044d183 to c6a07c0 Compare September 11, 2024 16:57
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from cb09170 to 03b7c20 Compare September 11, 2024 16:57
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from c6a07c0 to 8294561 Compare September 12, 2024 06:59
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 03b7c20 to ff561f2 Compare September 12, 2024 06:59
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 8294561 to 2afc05f Compare September 12, 2024 15:39
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from ff561f2 to a7e1f21 Compare September 12, 2024 15:39
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 2afc05f to ab9cfd9 Compare September 13, 2024 06:08
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from a7e1f21 to f0a34a7 Compare September 13, 2024 06:09
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from ab9cfd9 to 3180666 Compare September 13, 2024 07:13
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from f0a34a7 to 11d9608 Compare September 13, 2024 07:13
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 3180666 to dd74c17 Compare September 13, 2024 07:13
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 11d9608 to f5bd6af Compare September 13, 2024 07:14
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from dd74c17 to 785f4c9 Compare September 14, 2024 05:49
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from f5bd6af to 168c3f0 Compare September 14, 2024 05:49
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 785f4c9 to 78dfc66 Compare September 16, 2024 03:46
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 168c3f0 to 6400e13 Compare September 16, 2024 03:46
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 78dfc66 to 4768784 Compare September 18, 2024 06:15
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 6400e13 to 19a8def Compare September 18, 2024 06:15
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 4768784 to cba7561 Compare September 19, 2024 18:28
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 19a8def to cb864cf Compare September 19, 2024 18:28
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 1d16c73 to 5b4cbfe Compare November 9, 2024 00:12
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch 2 times, most recently from 67d0caf to 107f58a Compare November 9, 2024 05:50
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 5b4cbfe to 52b31dc Compare November 13, 2024 18:38
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 107f58a to 05296c1 Compare November 13, 2024 18:38
@bidetofevil bidetofevil marked this pull request as ready for review November 13, 2024 19:01
@bidetofevil bidetofevil requested a review from priettt November 14, 2024 19:23
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from 52b31dc to 54431ea Compare November 28, 2024 17:22
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch 2 times, most recently from 8b19675 to 2966135 Compare November 28, 2024 17:40
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs KDoc for the annotation that forms part of our new public API

@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from de0c371 to d320798 Compare November 29, 2024 16:41
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 2966135 to 3ba7d00 Compare November 29, 2024 16:41
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch from d320798 to d13a3e9 Compare November 29, 2024 18:10
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 3ba7d00 to f0b9b86 Compare November 29, 2024 18:10
@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch 2 times, most recently from f6ca940 to b27c99c Compare November 29, 2024 18:22
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from f0b9b86 to 2530415 Compare November 29, 2024 18:22
@bidetofevil bidetofevil changed the base branch from hho/open-event-emitter to graphite-base/1345 November 29, 2024 18:34
@bidetofevil bidetofevil force-pushed the hho/activity-trace-opt-in branch from 2530415 to f530e13 Compare November 29, 2024 18:38
@bidetofevil bidetofevil changed the base branch from graphite-base/1345 to main November 29, 2024 18:38
Copy link
Collaborator Author

bidetofevil commented Nov 29, 2024

Merge activity

  • Nov 29, 1:38 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Nov 29, 1:49 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit aa2f36a into main Nov 29, 2024
6 of 9 checks passed
@bidetofevil bidetofevil deleted the hho/activity-trace-opt-in branch November 29, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants