Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move init module to core #1141

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Moves the InitModule class and implementation to embrace-android-core. This will ultimately allow it to be accessed from embrace-android-features so features can be instantiated declaratively. I needed to move a few extension functions around to achieve this, and also:

  • Moved openTelemetryClock from InitModule to OpenTelemetryModule
  • Refactored serialization so that EmbraceUrl doesn't require an adapter, as the alternative is dragging a bunch of unrelated HTTPUrlConnection code over to the core module
  • Tweaked serialization function in NDK code

Testing

Updated existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner July 26, 2024 10:18
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.46%. Comparing base (f08cdc7) to head (ceff351).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           remove-apk-tools-config    #1141      +/-   ##
===========================================================
- Coverage                    81.47%   81.46%   -0.01%     
===========================================================
  Files                          439      439              
  Lines                        11541    11536       -5     
  Branches                      1786     1784       -2     
===========================================================
- Hits                          9403     9398       -5     
  Misses                        1356     1356              
  Partials                       782      782              
Files Coverage Δ
...embrace/android/embracesdk/internal/IdGenerator.kt 100.00% <100.00%> (ø)
...bracesdk/internal/clock/NormalizedIntervalClock.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/internal/clock/SystemClock.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/injection/InitModuleImpl.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/logging/EmbLoggerImpl.kt 64.70% <100.00%> (ø)
...ce/android/embracesdk/internal/spans/EmbraceExt.kt 100.00% <100.00%> (ø)
...esdk/internal/telemetry/EmbraceTelemetryService.kt 93.33% <100.00%> (ø)
...cesdk/internal/telemetry/OkHttpReflectionFacade.kt 55.55% <ø> (ø)
...al/telemetry/errors/EmbraceInternalErrorService.kt 66.66% <ø> (ø)
...al/telemetry/errors/InternalErrorDataSourceImpl.kt 100.00% <ø> (ø)
... and 26 more

... and 4 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I don't recall why the OTel clock has to be that low, but if you can move it to later and it still compiles, then awesome!

@fractalwrench fractalwrench force-pushed the remove-apk-tools-config branch from f08cdc7 to d0d514c Compare July 29, 2024 09:21
@fractalwrench fractalwrench requested a review from fnewberg as a code owner July 29, 2024 09:22
@fractalwrench fractalwrench merged commit 8e65ab6 into remove-apk-tools-config Jul 29, 2024
2 checks passed
@fractalwrench fractalwrench deleted the move-init-module branch July 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants