-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move init module to core #1141
Move init module to core #1141
Conversation
fc86af6
to
ceff351
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## remove-apk-tools-config #1141 +/- ##
===========================================================
- Coverage 81.47% 81.46% -0.01%
===========================================================
Files 439 439
Lines 11541 11536 -5
Branches 1786 1784 -2
===========================================================
- Hits 9403 9398 -5
Misses 1356 1356
Partials 782 782
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I don't recall why the OTel clock has to be that low, but if you can move it to later and it still compiles, then awesome!
f08cdc7
to
d0d514c
Compare
ceff351
to
2f37751
Compare
Move declaration of data sources to feature module
Move OpenTelemetry module
Goal
Moves the
InitModule
class and implementation toembrace-android-core
. This will ultimately allow it to be accessed fromembrace-android-features
so features can be instantiated declaratively. I needed to move a few extension functions around to achieve this, and also:openTelemetryClock
fromInitModule
toOpenTelemetryModule
EmbraceUrl
doesn't require an adapter, as the alternative is dragging a bunch of unrelated HTTPUrlConnection code over to the core moduleTesting
Updated existing test coverage.