Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for interrupted UI loads #1775

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Add tests for interrupted UI loads #1775

merged 1 commit into from
Dec 20, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Dec 19, 2024

Goal

Add tests to verify that interrupted load will still yield UI load traces

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Collaborator Author

bidetofevil commented Dec 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil force-pushed the hho/ui-load-interrupt branch from e1fd316 to d294274 Compare December 20, 2024 18:55
@bidetofevil bidetofevil marked this pull request as ready for review December 20, 2024 18:57
@bidetofevil bidetofevil requested a review from a team as a code owner December 20, 2024 18:57
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (81d68bb) to head (d294274).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
+ Coverage   85.42%   85.44%   +0.01%     
==========================================
  Files         466      466              
  Lines       10953    10953              
  Branches     1625     1625              
==========================================
+ Hits         9357     9359       +2     
+ Misses        866      864       -2     
  Partials      730      730              

see 1 file with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Dec 20, 2024

Merge activity

  • Dec 20, 4:51 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 20, 4:52 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit eac60be into main Dec 20, 2024
7 of 8 checks passed
@bidetofevil bidetofevil deleted the hho/ui-load-interrupt branch December 20, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants