Add option to manually end UI load trace #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bidetofevil
force-pushed
the
hho/ui-load-interrupt
branch
from
e1fd316 to
d294274
Compare
bidetofevil
force-pushed
the
hho/manual-end
branch
from
1e384d0 to
1eb9a2b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
=======================================
Coverage ? 85.44%
=======================================
Files ? 466
Lines ? 10979
Branches ? 1631
=======================================
Hits ? 9381
Misses ? 867
Partials ? 731
|
bidetofevil
force-pushed
the
hho/manual-end
branch
from
1eb9a2b to
cf59864
Compare
bidetofevil
requested review from
fractalwrench
and removed request for
a team
bidetofevil
changed the base branch from
hho/ui-load-interrupt
to
graphite-base/1776
bidetofevil
force-pushed
the
hho/manual-end
branch
from
cf59864 to
b2e071f
Compare
bidetofevil
force-pushed
the
hho/manual-end
branch
from
b2e071f to
a0bde6d
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add in the ability at the
UiLoadTraceEmitterlevel to designate a UI Load trace to be ended manually. This has not been hooked up with the API yet so it cannot be triggered externally yet.