Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract logic for constructing ApiRequest from ApiService #61

Merged
merged 1 commit into from
Nov 14, 2023

refactor: extract ApiRequest construction logic

a511645
Select commit
Loading
Failed to load commit list.
Merged

Extract logic for constructing ApiRequest from ApiService #61

refactor: extract ApiRequest construction logic
a511645
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 14, 2023 in 0s

82.81% of diff hit (target 75.74%)

View this Pull Request on Codecov

82.81% of diff hit (target 75.74%)

Annotations

Check warning on line 149 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/api/EmbraceApiService.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/api/EmbraceApiService.kt#L149

Added line #L149 was not covered by tests

Check warning on line 185 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/api/EmbraceApiService.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/api/EmbraceApiService.kt#L185

Added line #L185 was not covered by tests

Check warning on line 162 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/delivery/EmbraceDeliveryService.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/comms/delivery/EmbraceDeliveryService.kt#L162

Added line #L162 was not covered by tests