-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity: failed to get lun with # in its name #307
Labels
Comments
Murray-LIANG
added a commit
that referenced
this issue
May 21, 2020
The filter doesn't work when having \# char in name. Need to encode it before sending to Unity. Use a general function `urllib.parse.quote` to encode all chars except : and space. : and space chars are known working with Unity, eg. hostInitiator's initiatorID is string like iqn.1993-08.org.debian:01:a4f95ed19999 and sp name is `SP A`. And they are massively used in test cases. So, not to encode them to avoid introducing regression failure.
Murray-LIANG
added a commit
that referenced
this issue
May 22, 2020
The filter doesn't work when having \# char in name. Need to encode it before sending to Unity. Use a general function `urllib.parse.quote` to encode all chars except : and space. : and space chars are known working with Unity, eg. hostInitiator's initiatorID is string like iqn.1993-08.org.debian:01:a4f95ed19999 and sp name is `SP A`. And they are massively used in test cases. So, not to encode them to avoid introducing regression failure. This commit also changes some flake8 errors, the var named l is not allowed.
Murray-LIANG
added a commit
that referenced
this issue
May 22, 2020
The filter doesn't work when having \# char in name. Need to encode it before sending to Unity. Use a general function `urllib.parse.quote` to encode all chars except : and space. : and space chars are known working with Unity, eg. hostInitiator's initiatorID is string like iqn.1993-08.org.debian:01:a4f95ed19999 and sp name is `SP A`. And they are massively used in test cases. So, not to encode them to avoid introducing regression failure. This commit also changes some flake8 errors, the var named l is not allowed.
Murray-LIANG
added a commit
that referenced
this issue
May 25, 2020
The filter doesn't work when having \# char in name. Need to encode it before sending to Unity. Use a general function `urllib.parse.quote` to encode all chars except : and space. : and space chars are known working with Unity, eg. hostInitiator's initiatorID is string like iqn.1993-08.org.debian:01:a4f95ed19999 and sp name is `SP A`. And they are massively used in test cases. So, not to encode them to avoid introducing regression failure. This commit also changes some flake8 errors, the var named l is not allowed.
Murray-LIANG
added a commit
that referenced
this issue
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Storops should use escaped string like
Ansible%231lun
in REST url, but didn't.The text was updated successfully, but these errors were encountered: