Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flask8 variable name errors #313

Merged
merged 1 commit into from
May 22, 2020
Merged

Fix flask8 variable name errors #313

merged 1 commit into from
May 22, 2020

Conversation

Murray-LIANG
Copy link
Contributor

Variable cannot be named as l.

@Murray-LIANG
Fix flask8 variable name errors
3a01004 
Variable cannot be named as `l`.
@Murray-LIANG Murray-LIANG self-assigned this May 22, 2020
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #313 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   91.68%   91.69%           
=======================================
  Files          91       91           
  Lines       13297    13297           
  Branches     1601     1601           
=======================================
+ Hits        12192    12193    +1     
+ Misses        710      708    -2     
- Partials      395      396    +1
Impacted Files Coverage Δ
storops/lib/resource.py 91.63% <100.00%> (ø)
storops/unity/resource/nfs_share.py 84.21% <100.00%> (ø)
storops/lib/common.py 93.13% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ed0b7...3a01004. Read the comment docs.

@Murray-LIANG Murray-LIANG merged commit d01ef68 into master May 22, 2020
Murray-LIANG added a commit that referenced this pull request May 26, 2020
@Murray-LIANG
Release 1.2.5
3672bc3 
- Unity: skip hlu0 for snap host access (#314)
- [#307] Unity: fix url encoding (#312)
- Fix flask8 variable name errors (#313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-huang yong-huang Awaiting requested review from yong-huang

@amagicsun amagicsun Awaiting requested review from amagicsun

Assignees

@Murray-LIANG Murray-LIANG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Murray-LIANG