Merge order affects recommendation order #353
Assignees
Labels
bug
Something isn't working
Comments
Merged
Scienfitz
added a commit
that referenced
this issue
Sep 7, 2024
Fixes #353 Unintended reordering of discrete search space parts in `BotorchRecommender` was caused during pd.merging by the searchspace being on the left, however it should be on the right and the merge is safest done with `how='left'` while having the numerical points returned by botorch on the left -> the resulting rows will follow their order. A test has been written, perhaps though a little too complicated but anyhow. We can construct a searchspace/target construct where it would be expected that the order of the searchspace is strongly broken when getting recommendations (although I havent been able to create one that is exactly anti-ordered). In the faulty variant the recommendation order would still be monotonically increasing like in the searchspace, while the "correct" order is roughly anti-ordered, or strictly speaking `not monotonically increasing`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recommendations are expected to be provided in the order that the recommendation algorithm defines. Especially in greedy algorithms the order has meaning and should be preserved.
Currently, the order of discrete recommendations is changed by the merge to the searchspace, which should be fixed. Likely, this can be achieved by swapping left and right in the respective merges.
The text was updated successfully, but these errors were encountered: