Fix Recommendation Order for BotorchRecommender #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
reviewed
Sep 5, 2024
AVHopp
approved these changes
Sep 6, 2024
|
@AVHopp @AdrianSosic a commit for redesigning the hybrid recommendation merge is now up |
AdrianSosic
reviewed
Sep 6, 2024
Scienfitz
force-pushed
the
fix/recommendation_order
branch
from
8cfdb5a to
b72bafb
Compare
Scienfitz
force-pushed
the
fix/recommendation_order
branch
from
b72bafb to
d042e0e
Compare
Scienfitz
force-pushed
the
fix/recommendation_order
branch
from
14dd568 to
81a6159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Unintended reordering of discrete search space parts in
BotorchRecommenderwas caused during pd.merging by the searchspace being on the left, however it should be on the right and the merge is safest done withhow='left'while having the numerical points returned by botorch on the left -> the resulting rows will follow their order.A test has been written, perhaps though a little too complicated but anyhow. We can construct a searchspace/target construct where it would be expected that the order of the searchspace is strongly broken when getting recommendations (although I havent been able to create one that is exactly anti-ordered). In the faulty variant the recommendation order would still be monotonically increasing like in the searchspace, while the "correct" order is roughly anti-ordered, or strictly speaking
not monotonically increasing