Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egui-wgpu docs failed to build on docs.rs #3492

Closed
abey79 opened this issue Oct 21, 2023 · 4 comments · Fixed by #3909
Closed

egui-wgpu docs failed to build on docs.rs #3492

abey79 opened this issue Oct 21, 2023 · 4 comments · Fixed by #3909
Labels
bug Something is broken

Comments

@abey79
Copy link
Collaborator

abey79 commented Oct 21, 2023

See https://docs.rs/crate/egui-wgpu/0.23.0
@abey79 abey79 added the bug Something is broken label Oct 21, 2023
@abey79 abey79 added this to the 0.24.0 milestone Oct 21, 2023
@abey79
Copy link
Collaborator Author

abey79 commented Oct 21, 2023

I believe this is related to #3228. I got that error on my CI when updating to egui 0.23 (abey79/vsvg#54). Without the x11 or wayland feature, winit isn't able to detect the platform on linux (https://github.com/rust-windowing/winit/blob/772b21ce095b655f0fe50b89253910cd2ff9fa78/build.rs#L13). My workaround was to run that part on a mac runner, which is probably not an option for docs.rs.

@abey79
Copy link
Collaborator Author

abey79 commented Oct 22, 2023

winit issue: rust-windowing/winit#3173

@emilk emilk removed this from the 0.24.0 milestone Nov 21, 2023
@tgross35
Copy link
Contributor

This is still an issue at 0.24.0 https://docs.rs/crate/egui-wgpu/0.24.0

@tgross35
Copy link
Contributor

But they seem to build fine on my local, weird...

@Imberflur Imberflur mentioned this issue Jan 28, 2024
Closed
YgorSouza added a commit to YgorSouza/egui that referenced this issue Jan 28, 2024
@YgorSouza
Add x11 and wayland features to egui-wgpu and egui_glow
d38b982 
Closes emilk#3492 emilk#2286
@YgorSouza YgorSouza mentioned this issue Jan 28, 2024
Merged
emilk pushed a commit that referenced this issue Jan 30, 2024
@YgorSouza
Add x11 and wayland features to egui-wgpu and egui_glow (#3909)
d72f92c 
This allows them to build correctly on Linux by passing one or both of
the features alongside `winit`.

Closes #3492
Closes #2286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add x11 and wayland features to egui-wgpu and egui_glow YgorSouza/egui
3 participants
@emilk @tgross35 @abey79