Allow users to opt-out of default winit features
#3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
winit features
Speak2Erase
added a commit
to Speak2Erase/Luminol
that referenced
this pull request
Nov 20, 2023
Speak2Erase
added a commit
to Astrabit-ST/Luminol
that referenced
this pull request
Nov 22, 2023
* refactor: 🚧 Split luminol into separate crates * refactor: 🚧 Start working out dependencies * Sorta figure out dependencies * Sorta start getting somewhere * Move Luminol into crates folder * Move the filesystem trait out of luminol-core * refactor: 🚧 refactor luminol-graphics and it's a mess * refactor: * refactor: add UpdateState to luminol-core and move various traits * refactor(filesystem): ♻️ require FileSystem::File to be 'static * refactor: ♻️ don't take an &'static reference to graphics state * refactor: ♻️ refactor modals * refactor: ♻️ unify tabs and windows * refactor: ♻️ start to fix up windows * refactor: ♻️ hack together things so that they compile * refactor: ♻️ partially resolve async code issues * refactor: ♻️ it compiles (with a LOT of unfinished things) * refactor: ♻️ NOW it compiles * fix(graphics): 🐛 fix sprite shader compilation * fix(data cache): ♻️ get data cache semi-working * refactor(data cache): ♻️ actually load data cache * refactor(config): ♻️ store code theme in global state again * fix(ui): 🐛 fix windows and tabs not being added * refactor: ♻️ use workspace metadata for package metadata * refactor: ♻️ remove generic parameters on update state by using dynamic dispatch I couldn't get generics to allow adding tabs or windows inside tabs or windows * refactor(tabs): ♻️ pass update state when requesting tab name * fix(tabs): 🐛 fix tabs not adding properly * Update window.rs * fix: 🐛 get top bar loading projects * fix: 🐛 fix new project creation because reqwest requires tokio we need to spawn a tokio runtime. i do not think this scales well to web * refactor: 🚧 try splitting up the map tab * Enable -Zthreads compiler flag * Update nightly in workflows * revert: ⏪ Undo making cursor state an enum (will tackle this later) * Sorta resolve dependencies on wasm Still a mess (and is especially complicated by the fact that you can't specify workspace target specific dependencies) * Fix backing web filesystem implementation Still need to work on the project filesystem though! I'll be honest, I'm not sure how this will work, especially with the way I have the native filesystem set up * Fix native build * Remove jobs flag * Fix audio on wasm * Temporarily impl Send + Sync for wgpu callbacks In wgpu 0.17 wgpu types are not Send + Sync, because they reference things in the JS heap (meaning they cannot leave the thread they were created on) egui_wgpu's CallbackTrait requires Send + Sync even on wasm and we need to store wgpu types in callbacks. The callback_resources typemap passed to callbacks doesn't need to be Send + Sync.. but I can't find a simple way to add anything to the typemap. emilk/egui#1399 feels relevant * Fix winit not compiling in CI emilk/egui#3228 * Get wasm filesystem compiling * Get luminol compiling on wasm! * Fix missed rename * Dumb typo * Move luminol crate to be root package Trunk doesn't like virtual workspaces unfortunately :( * Run workspace tests * fix(audio): 🐛 Completely read audio file on wasm * perf(wasm): ⚡ Use oneshot crate for oneshot channels * fix(filesystem): 🐛 Pass idb key instead of path to Filesystem::from_idb_key * refactor(tilemap): ♻️ Use naga oil instead of const_format * fix(ui): 🐛 Fix top bar opening & closing projects * Bump nightly in trunk build * Remove luminol- in folder prefixes
mkeeter
added a commit
to mkeeter/fidget
that referenced
this pull request
Apr 12, 2024
This lets us work around emilk/egui#3228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to egui_winit: support winit with default features disabled #1971
Closes Wayland build error without wayland feature #3038
For
eframeandegui-winitthe following is now true:defaultfeatures includeswinit/default--no-default-features, nowinitfeatures are enabledwaylandfeature mapping towinit/wayland(see egui_winit: support winit with default features disabled #1971 for motivation)x11feature mapping towinit/x11, so we can test--no-default-features --features x11on CI.winitfeature flags, user can just depend onwinitthemselves