Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Change Arc<glow::Context> to Rc<glow::Context>" #3598 #3645

Closed
surban opened this issue Nov 27, 2023 · 0 comments · Fixed by #3646
Closed

Revert "Change Arc<glow::Context> to Rc<glow::Context>" #3598 #3645

surban opened this issue Nov 27, 2023 · 0 comments · Fixed by #3646

Comments

@surban
Copy link
Contributor

surban commented Nov 27, 2023

The changes introduced by #3598 were motivated by glow::Context becoming !Send + !Sync in version 0.13. The underlying issue in glow has since been fixed, making glow::Context Send + Sync again. A test case has been added to prevent such accidental breakages in the future.

Therefore this commit should be reverted to allow continued usage of egui in a multi-threaded environment.
@surban surban mentioned this issue Nov 27, 2023
Merged
emilk pushed a commit that referenced this issue Dec 4, 2023
@surban
Make glow Send + Sync again. (#3646)
36c6b63 
* Reverts #3598
* Closes #3645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make glow Send + Sync again surban/egui
1 participant
@surban