Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make glow Send + Sync again #3646

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Make glow Send + Sync again #3646

merged 3 commits into from
Dec 4, 2023

Conversation

surban
Copy link
Contributor

@surban surban commented Nov 27, 2023

@emilk emilk added this to the 0.25.0 milestone Nov 27, 2023
@emilk emilk added egui_glow Relates to running egui_glow on native eframe Relates to epi and eframe labels Nov 27, 2023
@emilk
Copy link
Owner

emilk commented Nov 27, 2023

Nice one! Unfortunately this is a breaking change, so will have to wait for the 0.25 release

@marshray
Copy link

marshray commented Dec 4, 2023

I'm working on my first egui project using glow and three-d.
It's just at the 'triangle' stage right now, but you can see it here.

Thanks for the great starting template @emilk! And for the fix @surban!

I have it working with patches, but it would be just super great if the three projects would release versions that work together.

Thanks,

  • Marsh

This is how I'm currently working around this:

ref: asny/three-d#421
ref: grovesNL/glow#268

@emilk emilk merged commit 36c6b63 into emilk:master Dec 4, 2023
20 of 21 checks passed
@emilk emilk changed the title Make glow Send + Sync again. Make glow Send + Sync again Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eframe Relates to epi and eframe egui_glow Relates to running egui_glow on native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert "Change Arc<glow::Context> to Rc<glow::Context>" #3598
3 participants