Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged changes #746

Closed
wants to merge 25 commits into from
Closed

Merged changes #746

wants to merge 25 commits into from

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Apr 12, 2024

Description

Merged changes from PRs #739, #740 and #742.

The aim of this PR is to have one place to fix failing tests. Real bugs to be addressed:

  • test_save.py: Sub-directories for catalogue files are not created even though the argument mkdir=True is provided to Ontology.save().
  • ontopy_tests/test_iri.py: Ontology.save() does now save turtle file.
  • tools/test_ontoconvert.py: The annotation comment is not available for copy_annotations().

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@jesper-friis
Copy link
Collaborator Author

Closing. most changes should have been taken care of by now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants