Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cttz_i8 is not defined [PATCH] #1353

Closed
oflebbe opened this issue Jul 7, 2013 · 3 comments
Closed

cttz_i8 is not defined [PATCH] #1353

oflebbe opened this issue Jul 7, 2013 · 3 comments

Comments

@oflebbe
Copy link

oflebbe commented Jul 7, 2013

Hi,

had the same issue running my ASM_JS app with -O3.

(Like
https://groups.google.com/forum/#!topic/emscripten-discuss/HbTT01LESqs)

Testcase and proposed patch appended. I do not see the point adding the undef cttz_i8 with Imprecise_64 bit integers. The symbol seems only needed for llvm_cttz_ functions.

Sorry, testcase is a little big ... I am in the middle of optimizing and had no time to strip it down. See README for compile flags.

Patch https://www.dropbox.com/s/nqpsfc458jdnt6p/0001-Fix-cttz_i8-undefined-with-O3-and-ASM_JS.patch
Testcase https://www.dropbox.com/s/py9nl9dad3t6vnv/rochelobe.tgz

@kripken
Copy link
Member

kripken commented Jul 7, 2013

Is the relevant part I64_PRECISE_MATH=0? (of the flags that -O3 flips)

@oflebbe
Copy link
Author

oflebbe commented Jul 8, 2013

Not sure what you want me to do: I used emcc -O2 with -s PRECISE_I64_MATH=0 with unmodified emscripten and got an internal error:

....
Assertion failed: Must have precise i64 math for non-constant 64-bit shifts
....

Olaf

Am 08.07.2013 um 01:29 schrieb Alon Zakai notifications@github.com:

Is the relevant part I64_PRECISE_MATH=0? (of the flags that -O3 flips)


Reply to this email directly or view it on GitHub.

@kripken
Copy link
Member

kripken commented Jul 8, 2013

Thanks, that's what I meant. So that code must require precise i64 math. That flag, like all -O3 options, can break code, looks like in this case it can't be used.

@oflebbe oflebbe closed this as completed Jan 11, 2019
aheejin added a commit to aheejin/emscripten that referenced this issue Mar 15, 2024
After emscripten-core#21518 landed, the previous 3.1.56 release (emscripten-core#1353) turned out to
be broken so we replaced 3.1.56 with the new one (emscripten-core#1360). So here to be
precise we update the date of the new 3.1.56 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants