Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.1.56's release date #21537

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Mar 15, 2024

After #21518 landed, the previous 3.1.56 release (emscripten-core/emsdk#1353) turned out to be broken so we replaced 3.1.56 with the new one (emscripten-core/emsdk#1360). So here to be precise we update the date of the new 3.1.56 release.

After emscripten-core#21518 landed, the previous 3.1.56 release (emscripten-core#1353) turned out to
be broken so we replaced 3.1.56 with the new one (emscripten-core#1360). So here to be
precise we update the date of the new 3.1.56 release.
@aheejin aheejin requested review from kripken and sbc100 March 15, 2024 00:08
@sbc100
Copy link
Collaborator

sbc100 commented Mar 15, 2024

I guess we need to force push the tag too? I actually hadn't realized that we had made a tag yes :-/ Force pushing a tag might have repercussions that we are not aware of, but I guess we have no choice now.

@aheejin
Copy link
Member Author

aheejin commented Mar 15, 2024

I guess we need to force push the tag too? I actually hadn't realized that we had made a tag yes :-/ Force pushing a tag might have repercussions that we are not aware of, but I guess we have no choice now.

I didn't push emsdk's 3.1.56 tag with the broken release, so that's fine. I will push it with the correct release once emscripten-core/emsdk#1360 lands.
For emscripten, I pushed 3.1.56 tag yesterday and deleted it from the repo this morning, and pushed the correct version just now. So technically the wrong tag was there in the emscripten repo for, like, overnight. I hope that's fine..?

@kripken
Copy link
Member

kripken commented Mar 15, 2024

I'm not aware of any workflows here or elsewhere that would mind. I think it's fine.

@aheejin aheejin merged commit 76aa717 into emscripten-core:main Mar 15, 2024
29 checks passed
@aheejin aheejin deleted the release_date branch March 15, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants