Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade error message when threads exit with live runtime. NFC #19048

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Downgrade error message when threads exit with live runtime. NFC #19048

merged 1 commit into from
Mar 23, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 23, 2023

Fixes: #19036

@sbc100 sbc100 changed the title Downgrade error message when threads exit with live runtime Downgrade error message when threads exit with live runtime. NFC Mar 23, 2023
@sbc100 sbc100 requested a review from tlively March 23, 2023 01:48
@tlively
Copy link
Member

tlively commented Mar 23, 2023

What is the difference between RUNTIME_DEBUG on its own and dbg on its own? Why combine them?

@sbc100
Copy link
Collaborator Author

sbc100 commented Mar 23, 2023

What is the difference between RUNTIME_DEBUG on its own and dbg on its own? Why combine them?

RUNTIME_DEBUG is enabled when any other logging channel is enabled. I use it for log information that you probably want if you are doing any kind of debugging at all.

@sbc100 sbc100 force-pushed the downgrade_error_message branch from 4c3dde3 to 8f3d300 Compare March 23, 2023 05:25
@sbc100 sbc100 merged commit a4e750e into main Mar 23, 2023
@sbc100 sbc100 deleted the downgrade_error_message branch March 23, 2023 05:25
@sbc100 sbc100 mentioned this pull request Mar 27, 2023
Closed
@pavelsavara pavelsavara mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider not logging an error when emscripten_unwind_to_js_event_loop is called when using -sASSERTIONS=1
2 participants
@sbc100 @tlively