Refactor line_endings.py. NFC #20735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
line_endings
branch
3 times, most recently
from
bf29a56 to
57282bc
Compare
sbc100
changed the title
sbc100
changed the title
kripken
reviewed
Nov 17, 2023
kripken
approved these changes
Nov 17, 2023
sbc100
force-pushed
the
line_endings
branch
3 times, most recently
from
4aa638c to
b3e1b4f
Compare
|
Based on the title, this will fix #20579? If so, worth adding to the description for auto-closing? |
auto-merge was automatically disabled
January 3, 2025 22:45
Pull request was closed
sbc100
changed the title
sbc100
force-pushed
the
line_endings
branch
8 times, most recently
from
c44fd98 to
9ae21ad
Compare
Most of the code in this file is used only for testing and is not part of emscripten proper, so move that code into test/line_endings.py Move the remaining utility functions to tools/utils.py. Update `write_file` utility so it can write a file with the correct line endings. This simplifies the callers who want to write a file with specific line endings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code in this file is used only for testing and is not part
of emscripten proper, so move that code into
test/line_endings.py.Move the remaining utility functions to
tools/utils.py.Update
write_fileutility so it can write a file with the correctline endings. This simplifies the callers who want to write a file
with specific line endings.