-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] AudioWorklet tests now correctly run and exit #23695
[test] AudioWorklet tests now correctly run and exit #23695
Conversation
Step one of a fix for #23131 (the second part in #23695). Enabled Chrome's `FakeAudioOutputStream` for the CI machines and bypassed the need for user interaction. The Chrome tests are now enabled with `@requires_sound_hardware`. Many attempts at replicating the same functionally were tried with Firefox (details below) but audio would never run so its `EMTEST_LACKS_SOUND_HARDWARE` was left unchanged.
0b97ea5
to
fd8b9ba
Compare
@sbc100 Would you prefer all of the AW tests working/enabled in batches like this, or all as one? |
How many AW tests are there? If all of the tests are to be changes like this in the same manor I think doing it all at once seems reasonable. |
If you are asking about landing the fixes at the same time as the test updates, I think those are good to keep separate. I I like this this change simply updates test code, for example. |
Mostly just the small collection of AW tests in the same section of code, and they should follow the same pattern. I’ll combine them together. I’ll keep the test with the audio files and mixer part of the separate current PR (because it’s larger). And again separately I’ll add this to the browser tests but disabled, since it’s broken: And any fixes, e.g. wasm64 and 2gb in their own PRs. |
Test timed out on CI but runs locally.
We're also ensuring the test runs, not just silently exits.
1cd9f52
to
555ccd4
Compare
Is this change ready to land now? |
Yes, this change is all done (as is the mixer PR). |
All the audio tests in
test_browser.py
(except the mixer) were updated now the CI has audio, specifically:btest_exit()
as previously discussedprintf
calls to Emscripten's API and not stdio)emscripten_force_exit
returning non-zero to verify they failed"Test success"
and other outputs for tests withoutrequires_sound_hardware
The mixer/AW struct test is a standalone PR in #23659.
Fixes: #23131