Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] AudioWorklet tests now correctly run and exit #23695

Merged
merged 17 commits into from
Feb 20, 2025
+46 −32
Merged

[test] AudioWorklet tests now correctly run and exit #23695

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8c964d1
Flag to run and exit AW test
cwoffenden Feb 18, 2025
10eb2ef
Tests test_audio_worklet and test_audio_worklet_modularize will timeout
cwoffenden Feb 18, 2025
b8952bc
Re-added DTEST_AND_EXIT'
cwoffenden Feb 18, 2025
65e3aec
Removed wasm64 tests for now
cwoffenden Feb 18, 2025
746d917
2GB tests need the same wasm64 fixes
cwoffenden Feb 19, 2025
d2c1624
Already runs as part of (failing) wasm64 tests
cwoffenden Feb 19, 2025
9b8bf0b
Something to rerun browser_2gb.test_offset_converter_pthread
cwoffenden Feb 19, 2025
ac04587
Move test over to btest_exit()
cwoffenden Feb 20, 2025
555ccd4
Minor tidy
cwoffenden Feb 20, 2025
dc5ccb8
Note about testing requirements
cwoffenden Feb 20, 2025
156db10
Superfluous header
cwoffenden Feb 20, 2025
ed0fb23
Superfluous header
cwoffenden Feb 20, 2025
47a7c0b
Migrated test to btest_exit()
cwoffenden Feb 20, 2025
982e344
Migrated to btest_exit()
cwoffenden Feb 20, 2025
2783268
Improve how failures are reported and seen in the CI
cwoffenden Feb 20, 2025
61e5c7a
Suggested review changes
cwoffenden Feb 20, 2025
1fb8bda
Not paying attention...
cwoffenden Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/webaudio/audioworklet.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ bool main_thread_tls_access(double time, void *userData) {
// added to the Worklet global scope.
void AudioWorkletProcessorCreated(EMSCRIPTEN_WEBAUDIO_T audioContext, bool success, void *userData) {
if (!success) {
emscripten_out("Stopped in AudioWorkletProcessorCreated");
assert(0);
assert("Stopped in AudioWorkletProcessorCreated" && success);
return;
}

Expand Down Expand Up @@ -114,8 +113,7 @@ void AudioWorkletProcessorCreated(EMSCRIPTEN_WEBAUDIO_T audioContext, bool succe
// Processors.
void WebAudioWorkletThreadInitialized(EMSCRIPTEN_WEBAUDIO_T audioContext, bool success, void *userData) {
if (!success) {
emscripten_out("Stopped in WebAudioWorkletThreadInitialized");
assert(0);
assert("Stopped in WebAudioWorkletThreadInitialized" && success);
return;
}

Expand Down
Loading