-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Warn that SUPPORT_BIG_ENDIAN is experimental
#25058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SUPPORT_BIG_ENDIAN is experimental
Support for big endian targets is "best effort" and not fully supported or tested.
|
I know this is well-intentioned, though this PR now disrupts running the E.g. I don't think that it would be productive to modify each test to account for this warning message being possibly present.. probably would be simplest to just revert this? (I don't think there have ever been people complaining about expectations around -sSUPPORT_BIG_ENDIAN so far?) |
The change to make this config as experimental (emscripten-core#25058) raced with that adding of the test suite (emscripten-core#25068). Adding `-Wno-experimental` here like we do for other such configurations (e.g. wasm64).
|
Sorry the marking as experimental raced with the adding of the new test config. Fix is in #25090 |
Support for big endian targets is "best effort" and not fully supported or tested.
Also, as far as I'm aware there is only one or two users of this feature so I think it makes sense for it to stay as "best effort" for the foreseeable future.
See #25042