Add bigendian test suite #25068
Merged
Add bigendian test suite #25068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/test_core.py
sbc100
approved these changes
Aug 27, 2025
| # The above test scheme has a small quirk that it will also use the Big Endian version of node.js for internal | ||
| # Emscripten compilation. At a quick test, this actually worked, so maybe this would be fine for this test harness. | ||
| # Alternatively, we would want to find a way to separate compiler node from runtime node somehow in the harness. | ||
| bigendian0 = make_run('bigendian0', cflags=['-O0'], settings={'SUPPORT_BIG_ENDIAN': 1}) |
Collaborator
There was a problem hiding this comment.
These instruction can be updated to use NODE_JS_TEST
Collaborator
Author
There was a problem hiding this comment.
I wasn't able to make NODE_JS_TEST to work so far. See #25063 (comment)
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 28, 2025
The change to make this config as experimental (emscripten-core#25058) raced with that adding of the test suite (emscripten-core#25068). Adding `-Wno-experimental` here like we do for other such configurations (e.g. wasm64).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
bigendian0test suite that can be used to verify big endian compilation support.