Skip to content

Add bigendian test suite #25068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juj merged 4 commits into from
Aug 27, 2025
Merged

Add bigendian test suite #25068

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da234bf
Try out how a bigendian suite could work out.
juj Aug 25, 2025
46a2cdf
Add a mechanism to skip tests that do not work in big endian mode.
juj Aug 26, 2025
93cb3de
bigendian0
juj Aug 27, 2025
954f2a4
Merge remote-tracking branch 'origin/main' into bigendian_test_suite
juj Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ def decorated(self, textdecoder, *args, **kwargs):
no_safe_heap = make_no_decorator_for_setting('SAFE_HEAP')
no_strict = make_no_decorator_for_setting('STRICT')
no_strict_js = make_no_decorator_for_setting('STRICT_JS')
no_big_endian = make_no_decorator_for_setting('SUPPORT_BIG_ENDIAN')


def is_sanitizing(args):
Expand Down Expand Up @@ -6631,6 +6632,7 @@ def test_neon_wasm_simd(self):
'': ([],),
'nontrapping': (['-mnontrapping-fptoint'],),
})
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_sse1(self, args):
src = test_file('sse/test_sse1.cpp')
self.run_process([shared.CLANG_CXX, src, '-msse', '-o', 'test_sse1', '-D_CRT_SECURE_NO_WARNINGS=1'] + clang_native.get_clang_native_args(), stdout=PIPE)
Expand All @@ -6651,6 +6653,7 @@ def test_sse1(self, args):
'': ([],),
'nontrapping': (['-mnontrapping-fptoint'],),
})
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_sse2(self, args):
src = test_file('sse/test_sse2.cpp')
self.run_process([shared.CLANG_CXX, src, '-msse2', '-Wno-argument-outside-range', '-o', 'test_sse2', '-D_CRT_SECURE_NO_WARNINGS=1'] + clang_native.get_clang_native_args(), stdout=PIPE)
Expand All @@ -6664,6 +6667,7 @@ def test_sse2(self, args):
@wasm_simd
@requires_native_clang
@requires_x64_cpu
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_sse3(self):
src = test_file('sse/test_sse3.cpp')
self.run_process([shared.CLANG_CXX, src, '-msse3', '-Wno-argument-outside-range', '-o', 'test_sse3', '-D_CRT_SECURE_NO_WARNINGS=1'] + clang_native.get_clang_native_args(), stdout=PIPE)
Expand All @@ -6677,6 +6681,7 @@ def test_sse3(self):
@wasm_simd
@requires_native_clang
@requires_x64_cpu
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_ssse3(self):
src = test_file('sse/test_ssse3.cpp')
self.run_process([shared.CLANG_CXX, src, '-mssse3', '-Wno-argument-outside-range', '-o', 'test_ssse3', '-D_CRT_SECURE_NO_WARNINGS=1'] + clang_native.get_clang_native_args(), stdout=PIPE)
Expand All @@ -6692,6 +6697,7 @@ def test_ssse3(self):
@requires_native_clang
@requires_x64_cpu
@is_slow_test
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_sse4_1(self):
src = test_file('sse/test_sse4_1.cpp')
# Run with inlining disabled to avoid slow LLVM behavior with lots of macro expanded loops inside a function body.
Expand All @@ -6710,6 +6716,7 @@ def test_sse4_1(self):
'': (False,),
'2': (True,),
})
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_sse4(self, use_4_2):
msse4 = '-msse4.2' if use_4_2 else '-msse4'
src = test_file('sse/test_sse4_2.cpp')
Expand All @@ -6731,6 +6738,7 @@ def test_sse4(self, use_4_2):
'': ([],),
'nontrapping': (['-mnontrapping-fptoint'],),
})
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_avx(self, args):
src = test_file('sse/test_avx.cpp')
self.run_process([shared.CLANG_CXX, src, '-mavx', '-Wno-argument-outside-range', '-Wpedantic', '-o', 'test_avx', '-D_CRT_SECURE_NO_WARNINGS=1'] + clang_native.get_clang_native_args(), stdout=PIPE)
Expand All @@ -6751,6 +6759,7 @@ def test_avx(self, args):
'': ([],),
'nontrapping': (['-mnontrapping-fptoint'],),
})
@no_big_endian('SIMD support is currently not compatible with big endian')
def test_avx2(self, args):
src = test_file('sse/test_avx2.cpp')
self.run_process([shared.CLANG_CXX, src, '-mavx2', '-Wno-argument-outside-range', '-Wpedantic', '-o', 'test_avx2', '-D_CRT_SECURE_NO_WARNINGS=1'] + clang_native.get_clang_native_args(), stdout=PIPE)
Expand Down Expand Up @@ -10034,5 +10043,27 @@ def setUp(self):
minimal0 = make_run('minimal0', cflags=['-g'], settings={'MINIMAL_RUNTIME': 1})
llvmlibc = make_run('llvmlibc', cflags=['-lllvmlibc'])

# To run the big endian test suite on a little endian Linux host:
# 1. sudo apt install -y qemu-user libc6-s390x-cross libstdc++6-s390x-cross
# 2. wget https://nodejs.org/dist/v22.16.0/node-v22.16.0-linux-s390x.tar.xz
# 3. tar xJf node-v22.14.0-linux-s390x.tar.xz
# 4. run a little endian emsdk install, e.g. `emsdk install sdk-main-64bit`
# 5. activate little endian emsdk install, e.g. `emsdk activate sdk-main-64bit`
# 6. modify the generated emsdk install: edit file .emscripten under emsdk/ root directory, and change the line
# NODE_JS = emsdk_path + '/node/22.16.0_64bit/bin/node'
# to point to big endian node:
# NODE_JS = ['qemu-s390x', '-L', '/usr/s390x-linux-gnu/', '/home/user/node-v22.16.0-linux-s390x/bin/node']
# 7. enter emsdk environment in current terminal with `source ./emsdk_env.sh`
# 8. modify EMSDK_NODE environment variable to also point to the big endian node:
# export EMSDK_NODE="qemu-s390x -L /usr/s390x-linux-gnu/ /home/user/node-v22.16.0-linux-s390x/bin/node"
# 9. run some tests in big endian mode: in Emscripten root directory, run
# `test/runner bigendian` to run all tests, or a single test with
# `test/runner bigendian.test_jslib_i64_params`

# The above test scheme has a small quirk that it will also use the Big Endian version of node.js for internal
# Emscripten compilation. At a quick test, this actually worked, so maybe this would be fine for this test harness.
# Alternatively, we would want to find a way to separate compiler node from runtime node somehow in the harness.
bigendian0 = make_run('bigendian0', cflags=['-O0'], settings={'SUPPORT_BIG_ENDIAN': 1})
Copy link
Collaborator

@sbc100 sbc100 Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instruction can be updated to use NODE_JS_TEST

Copy link
Collaborator Author

@juj juj Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to make NODE_JS_TEST to work so far. See #25063 (comment)


# TestCoreBase is just a shape for the specific subclasses, we don't test it itself
del TestCoreBase # noqa