Fix SQLite fetch queries with multiple parameters #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLAlchemy 1.4 no longer orders `compiled.bind_names` the same as the sequence of `?` placeholders in the generated SQL. We must iterate keys from `compiled.positiontup` that stores the correct order of bound parameters. Backport of athenianco#5
aminalaee
approved these changes
Dec 2, 2021
|
@aminalaee Is there a chance for a new release with this change included? |
|
I'll prepare the PR for review. It would be great if #436 could also go with this release. |
@aminalaee Can you ping someone from maintainers to review #436 (it's also waiting one month already)? I'm not sure who from @encode is still engaged with this project. |
|
I'll try to push it through. I hope more maintainers can help with this project and orm. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLAlchemy 1.4 no longer orders
compiled.bind_namesthe same as the sequence of?placeholders in the generated SQL. We must iterate keys fromcompiled.positiontupthat stores the correct order of bound parameters.Backport of athenianco#5