chore(ses): Advance Node.js compatibility test from version 10 to 12 #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kris-goes-up-to-eleven
branch
from
44f9480 to
17c44e3
Compare
|
ping. You've already enables auto-merge, but it seems stuck in CI. pinging because #1306 waits for this one. |
|
The problem was the branch protection rules were looking for the mispelling. The branch wasn't up to date with master so I used GH UI to update with rebase. |
turadg
force-pushed
the
kris-goes-up-to-eleven
branch
from
17c44e3 to
92194e3
Compare
This was referenced Aug 19, 2024
erights
added a commit
that referenced
this pull request
Aug 27, 2024
Closes: #2418 Refs: #2417 #1308 ## Description Adapted from #2419 (review) below The platform compatibility test specifically validates that SES works on Node.js 12 and can be deleted since it has vanished into history. Node.js 12 required special consideration because of its experimental ESM support. Delete the `test:platform-compatibility` script in the ses `package.json`, as well as the `test/package` fixture in ci.yml Immediate motivation explained in #2418 , #2417 broken the platform-compatibility-test tests because it depends on the platform providing either `Array.prototype.transfer` or `structuredClone`. Node supports `transfer` starting with Node 22, but supports `structuredClone` starting in Node 18. That should be fine, since that is our declared support floor. This PR changes our one known remaining dependence on Node 12. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none beyond the need to explain our platform requirements, which this PR does not change. ### Testing Considerations The point. This PR only affects tests, not production code. Reviewers, should this PR be labeled `test:` instead of `fix:`? ### Compatibility and Upgrade Considerations After this PR, we will no longer notice further breakage on Node < 18. That fits with our declared support floor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1306, we have an invalid
Object.fromEntriesshim that is only needed before Node.js 12 and analogous browsers. This change raises the tested lockdown compatibility floor up to Node.js 12.