spike on PNPM #1722
Draft
spike on PNPM #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
kriskowal
added a commit
that referenced
this pull request
Apr 26, 2024
closes: #2245 refs: Agoric/agoric-sdk#451 refs: Agoric/ui-kit#105 ## Description Move from Yarn 1 to Yarn 4. Some advantages, - actively maintained - [workspace protocol](https://yarnpkg.com/protocol/workspace) (so we don't have to maintain version numbers in all deps) - [patch protocol](https://yarnpkg.com/protocol/patch) (so we don't need patch-package) - [constraints](https://yarnpkg.com/features/constraints) (e.g. to enforce layering) - path to adopt pnpm-style linker (without changing the UI) (see #1722 ) However this defers workspace protocol until the publishing workflow can support it. ### Security Considerations This does a bulk update of `yarn.lock`. It was automated by Yarn 4. ### Scaling Considerations n/a ### Documentation Considerations I reviewed `yarn` commands in *.md and I think they're all accurate. ### Testing Considerations This could interact with the publishing pipeline. @kriskowal may want to push a draft before we merge. If problems are found, depending on the severity, we could follow up in a separate PR to land this sooner reduce merge conflicts. This was failing on the Windows tests, something about corepack not taking effect. I don't know whether Windows is officially supported by Endo. We've since disabled them. #2243 is the issue restore. ### Compatibility Considerations Some CLI commands are slightly different. We are adopting it across the org so we have to adjust sometime. ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations