upgrade to Yarn 4 #2222
Merged
upgrade to Yarn 4 #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/yarn-4
branch
4 times, most recently
from
c415a8f
to
d860523
Compare
|
I’m interested in giving this a shot (and willing to suffer reverting it if it gets in the way of the sync cycle). I’m reluctantly willing to entertain dropping Windows from CI to unblock this (and reduce occurrences of flakey tests that Windows CI reveals more often than Linux.) Windows support is hard to get back once lost. May I ask for an Agoric SDK CI job pinned to this branch? |
kriskowal
added a commit
that referenced
this pull request
Apr 24, 2024
We’ve seen a lot of EPIPE on write failures that are more common on Windows than Linux/Mac, though they do occur. For that reason along, it would be good to restore Windows CI when we track that issue down, but for now, the flakes are too hard to bear and also block us from upgrading yarn #2222 Tracking revert #2243
turadg
force-pushed
the
ta/yarn-4
branch
3 times, most recently
from
ca5e5c7
to
d8e1867
Compare
|
Integration probe Agoric/agoric-sdk#9285 |
This was referenced Apr 25, 2024
Closed
Closed
Following https://yarnpkg.com/migration/guide: yarn set version berry yarn install
Yarn 4 is more strict
mergify bot
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Apr 26, 2024
refs: #451 refs: #9209 ## Description We need agoric-sdk's integration tests to work with Endo running Yarn 4. #9285 tested against endojs/endo#2222. This PR is to land the necessary changes in master so the Endo PR can land without breaking SDK CI. This helps with #9209 and is a subset of #9286 , all that we need for Endo right now. ### Security Considerations none ### Scaling Considerations none, build time ### Documentation Considerations Nothing for SDK ### Testing Considerations CI ### Upgrade Considerations n/a
kriskowal
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2245
refs: Agoric/agoric-sdk#451
refs: Agoric/ui-kit#105
Description
Move from Yarn 1 to Yarn 4. Some advantages,
However this defers workspace protocol until the publishing workflow can support it.
Security Considerations
This does a bulk update of
yarn.lock. It was automated by Yarn 4.Scaling Considerations
n/a
Documentation Considerations
I reviewed
yarncommands in *.md and I think they're all accurate.Testing Considerations
This could interact with the publishing pipeline. @kriskowal may want to push a draft before we merge. If problems are found, depending on the severity, we could follow up in a separate PR to land this sooner reduce merge conflicts.
This was failing on the Windows tests, something about corepack not taking effect. I don't know whether Windows is officially supported by Endo. We've since disabled them. #2243 is the issue restore.
Compatibility Considerations
Some CLI commands are slightly different. We are adopting it across the org so we have to adjust sometime.
Upgrade Considerations
n/a