Skip to content

Commit

Permalink
[flutter_markdown] Fix changelog regarding minimum supported SDK vers…
Browse files Browse the repository at this point in the history
…ion (flutter#4851)

The changelog of the `flutter_markdown` package is a bit confusing. First it says:

> Updates minimum supported SDK version to Flutter 3.10/Dart 3.0

and in the latest update is says

> Updates minimum supported SDK version to Flutter 3.7/Dart 2.19

Just from reading this I would expect that the minimum SDK lowered with the latest update. However, this is not the case.

After a bit of researching, I found this was caused by flutter/packages#4731. The mentioned PR only updates the minimum SDK of the example but not of the package, see: https://github.com/flutter/packages/pull/4731/files#diff-e780ee3aec5fdc10512b452b5464878a11caf22fb23d28f725324308ad243d17R6

Therefore, I clarified the changelog with this PR.

![telegram-cloud-photo-size-2-5456132896298487892-y](https://github.com/flutter/flutter/assets/24459435/c992917a-7eda-4e45-a656-50408a6c8910)

<img width="819" alt="image" src="https://github.com/flutter/flutter/assets/24459435/bee2f046-ea86-45c7-9567-a19949e3e6f8">

Fixes flutter#134056

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
  • Loading branch information
nilsreichardt authored Sep 12, 2023
1 parent b04d2cc commit c9fbe4e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion packages/flutter_markdown/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
## 0.6.17+3

* Fixes an incorrect note about SDK versions in the 0.6.17+2 CHANGELOG.md entry.

## 0.6.17+2

* Adds pub topics to package metadata.
* Updates minimum supported SDK version to Flutter 3.7/Dart 2.19.

## 0.6.17+1

Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_markdown/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Markdown renderer for Flutter. Create rich text output,
formatted with simple Markdown tags.
repository: https://github.com/flutter/packages/tree/main/packages/flutter_markdown
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_markdown%22
version: 0.6.17+2
version: 0.6.17+3

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down

0 comments on commit c9fbe4e

Please sign in to comment.